Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ja locale #117

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

savvan0h
Copy link
Contributor

Hi, I found a typo in invalid_security_question and fixed it.

@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2019

Pull Request Test Coverage Report for Build 452

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.796%

Totals Coverage Status
Change from base Build 451: 0.0%
Covered Lines: 1185
Relevant Lines: 1237

💛 - Coveralls

@@ -18,7 +18,7 @@ ja:
other: は最低%{count}つの大文字英字を含む必要があります。
devise:
invalid_captcha: 'キャプチャ入力が不正です。'
invalid_security_question: 'セキュリティ質問に対すつ回答が不正です。'
invalid_security_question: 'セキュリティ質問に対する回答が不正です。'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the typo fix is => ? Can you explain what the difference is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 対すつ should be 対する that means to as in "The answer to the security question was invalid". 対すつ just doesn't make sense because of the typo.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not native Japanese but I confirm, it's 100%

@dillonwelch dillonwelch merged commit 7aa7d34 into devise-security:master Jul 18, 2019
@olbrich olbrich added 🐛 bug #️⃣.#️⃣.#️⃣ Patch backwards-compatible bug fixes labels Jul 20, 2019
@olbrich olbrich added this to the 0.15.0 milestone Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug #️⃣.#️⃣.#️⃣ Patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants