Invert negative signal to sort on 6.1 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I will setup a 6.1 box to test this :D - |
Contributor
Author
|
Indeed it seems that the sign of the signal value may depend of the driver: |
Member
I thought this sounded familiar... #8 (comment) |
The signal can be a negative dBm or a positive percentage depending of the capabilities of the driver. We must convert the value into a positive integer to allow to sort in all cases.
Contributor
Author
|
I reworked the patch to take care of both cases dBm and %. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 6.1, the signal is negative dBm. So to still have a sort with the
stronger signal on top, the signal must be inverted.