Skip to content

Apply fixes from StyleCI #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Apply fixes from StyleCI #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/LaravelHyperpay.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LaravelHyperpay implements Hyperpay
* @var string brand
*/
protected $brand;

/**
* @var string redirect_url
*/
Expand Down Expand Up @@ -84,7 +84,6 @@ public function addBilling(BillingInterface $billing)

return $this;
}


/**
* Prepare the checkout.
Expand Down Expand Up @@ -178,7 +177,7 @@ public function addMerchantTransactionId($id)
}

/**
* Add redirection url to the shopper to finalize the payment
* Add redirection url to the shopper to finalize the payment.
*
* @param string $url
*
Expand Down
5 changes: 2 additions & 3 deletions src/Support/HttpResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function addScriptUrl($base_url)
*/
public function addShopperResultUrl($redirect_url)
{
$url = $redirect_url ?:config('hyperpay.redirect_url');
$url = $redirect_url ?: config('hyperpay.redirect_url');

$this->shopperResultUrl = $url;

Expand Down Expand Up @@ -237,10 +237,9 @@ protected function updateTransaction($status, array $optionData)
}
}


/**
* Check the response status get it from hyperpay
* if bad convert it to the ValidationException
* if bad convert it to the ValidationException.
*
* @return mixed
*/
Expand Down