-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: aarch64 (original, plain, line) #1961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON and the icon formats are good. Just wondering through but there appears to be some artifacts on the the SVGs.
Haven't found an HD version of the Icon anywhere, so I guess it was some artifacts left over from an image upscaler. It does seem to be a part of the original PR though:
If it's a non-issue, then I can approve the PR.
@canaleal I saw that too, but assumed it was a part of the logo since it was there in the original version. |
@canaleal The original icon was created by converting a PNG (since there were no SVG's available) in this PR: #507 I redid the icon using a slightly higher resolution JPEG, which I found with this reverse image search: Here's the resulting SVG after converting it using Inkscape: It looks a bit better compared to the old one: It's not perfect... especially not the text, but I don't have the skills to fix it myself, so I suggest we merge this PR and create a separate issue about fixing the path of the icons, especially the text. |
Converted to raster with: https://vectorizer.ai/ Corrected color palette with: https://svgcolor.com
Actually I found an awesome tool to convert Raster images to PNG: https://vectorizer.ai/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find! Also nice work as always.
How to convert bitmap/raster images (
|
Since this icon needs to be updated for the upcoming release, I'll merge it with only 1 approval. Please do review it even after it's merged though, so I'll know if something is wrong :) |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereChanges
Optimize icons, add alias to wordmark versions and add line version