Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: lodash (original, plain) #1879

Merged
merged 10 commits into from
Dec 5, 2023
Merged

new icon: lodash (original, plain) #1879

merged 10 commits into from
Dec 5, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 4, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1837

Link to prove your SVG is correct and up-to-date.

https://lodash.com/

@weh weh changed the base branch from master to develop October 4, 2023 16:24
Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Padding on the icons should be removed here too :)

@weh weh force-pushed the feature/1837-add-lodash-icon branch from ef5cd2d to 24d100e Compare October 23, 2023 11:34
@weh
Copy link
Contributor Author

weh commented Oct 23, 2023

Removed padding and rebased to develop

@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2023
Snailedlt
Snailedlt previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now! 🥇
Great job as always @weh 🚀

@Snailedlt Snailedlt requested review from a team, ConX, canaleal and lunatic-fox and removed request for a team October 24, 2023 15:54
@Snailedlt Snailedlt requested a review from Panquesito7 October 24, 2023 19:02
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 30, 2023
lunatic-fox
lunatic-fox requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! 👍🏼
Just some tiny adjustments. 🔧

icons/lodash/lodash-original.svg Outdated Show resolved Hide resolved
icons/lodash/lodash-plain.svg Outdated Show resolved Hide resolved
@weh @lunatic-fox
Update icons/lodash/lodash-original.svg
401f193 
remove #000 fill

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
weh and others added 2 commits November 6, 2023 18:02
@weh @lunatic-fox
Update icons/lodash/lodash-plain.svg
a8c4fcb 
remove #000 fill

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@weh
Merge branch 'develop' into feature/1837-add-lodash-icon
ccf3d7d
@weh weh requested a review from lunatic-fox November 6, 2023 17:03
lunatic-fox
lunatic-fox approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be okay now! 👍🏼
Thank you for this contribution! 🚀
image

@lunatic-fox lunatic-fox requested a review from Snailedlt November 9, 2023 22:43
canaleal
canaleal approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. All is good.

@Snailedlt
Copy link
Collaborator

Merging this since it has two approvals :)

@Snailedlt Snailedlt merged commit 84dfbea into devicons:develop Dec 5, 2023
4 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@weh @Snailedlt @lunatic-fox
new icon: lodash (original, plain) (devicons#1879)
c7a173a 
* Add lodash icon

* Remove padding

* Update icons/lodash/lodash-original.svg

remove #000 fill

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

* Update icons/lodash/lodash-plain.svg

remove #000 fill

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: lodash
4 participants
@weh @Snailedlt @canaleal @lunatic-fox