new icon: yugabytedb (original, original-wordmark, plain, plain-wordmark) #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ungroup `original`, `original-wordmark` and `plain-wordmark` - Unify path of `plain-wordmark` version
Panquesito7
added
the
feature:icon
Panquesito7
reviewed
Jul 21, 2023
Co-authored-by: David Leal <halfpacho@gmail.com>
|
Maybe someone can review these changes and see if there's any issue with them or recommendations? |
Snailedlt
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
LGTM! ✔️
Thank you for the contribution! 🙇
PS: Sorry for the incredibly late review. All of the maintainers have been busy pretty much all year, which is why we are looking for new maintainers. If that's something you'd want to apply to, please check out this discussion: #1436
Snailedlt
requested review from
a team,
ConX,
canaleal and
lunatic-fox
and removed request for
a team
lunatic-fox
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
I got the SVG from the home page of their official website