Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: insomnia (original, original-wordmark, plain, plain-wordmark) #1513

Merged
merged 33 commits into from
Feb 17, 2023

Conversation

seyitErdemir
Copy link
Contributor

@seyitErdemir seyitErdemir commented Nov 18, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

@seyitErdemir seyitErdemir changed the title Insomnia add new icon : Insomnia (original, original-wordmark) Nov 18, 2022
@lunatic-fox lunatic-fox changed the base branch from master to develop November 18, 2022 19:50
@lunatic-fox
Copy link
Contributor

lunatic-fox commented Nov 18, 2022

Hello there!
There are some problems with this pull request:

  • ❌ You must be comparing your forked branch with devicon:develop

    Already fixed!

  • ❌ The icons can't be images (raster) inside a SVG
  • ❌ Icons are not following the SVG Standards
  • ❌ Except for devicon.json and the icons/<PR ICON>/*.svg files, no other file can be changed

    package.json and package-lock.json are changed.

  • ❌ PR filenames and devicon.json related entry are not corresponding

Any questions: read the Wiki or ask in Discord.

@lunatic-fox lunatic-fox changed the title new icon : Insomnia (original, original-wordmark) new icon: insomnia (original, original-wordmark) Nov 18, 2022
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 19, 2022
@cyberalien
Copy link
Contributor

You just wrapped PNG images in SVG tag. Those are not vector logos.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for making a PR!

Like both @cyberalien and @lunatic-fox already mentioned, the icons don't meet our criteria. I've suggested some changes to get this merged ASAP :)

I also recommend that you take a look at our wiki to get a bit more info on how you can make better contributions. Specifically you should look at Overview on Submitting Icons

icons/insomnia/insomnia.svg Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
icons/insomnia/insomnia-wordmarker.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/insomnia/insomnia-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

1 similar comment
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/insomnia/insomnia-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Fix devicon.json file
 - Change to correct color
 - Add open-source tag
 - Remove font since no icons are mono colored
 - Remove whitespace
 - Fix versions.svg array
@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'insomnia-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'insomnia-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to devicon.json and renamed the icon filenames.

Now you just need to resize the icons so they have viewbox 0 0 128 128, and are centered (see SVG-Standards for more info). I recommend resizing using iloveimg from our Recommended Resources and Tools wiki page.

Then after that you can optimize the icons by following this guide

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually all the icons look good now 💯
Just need to optimize them, then we're good to merge :)

devicon.json Outdated Show resolved Hide resolved
icons/insomnia/insomnia-original-wordmark.svg Outdated Show resolved Hide resolved
icons/insomnia/insomnia-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/insomnia/insomnia-plain.svg Outdated Show resolved Hide resolved
@Panquesito7
Copy link
Member

Hey there. Do you need any help with this, @seyitErdemir?

@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Feb 15, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox changed the title new icon: insomnia (original, original-wordmark) new icon: insomnia (original, original-wordmark, plain, plain-wordmark) Feb 15, 2023
lunatic-fox
lunatic-fox previously approved these changes Feb 17, 2023
Snailedlt
Snailedlt previously approved these changes Feb 17, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! ✔️
I noticed there's an extra newline at the end of each file, so if you can, please remove it :)

Other than that, great work! Thank you for the contribution! 💯

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 17, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox merged commit f42f80c into devicons:develop Feb 17, 2023
@seyitErdemir seyitErdemir deleted the insomnia_add branch February 17, 2023 16:22
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants