lopper/assists: Move non-address-mapped subnodes from '/amba_pl' to root #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2025 17:03
In the Linux device tree, subnodes within the '/amba_pl' node that lack both 'reg' and 'ranges' properties are considered non-address-mapped. To prevent device link failures, such subnodes are now relocated to the root node. This applies only to direct children of '/amba_pl' and excludes nodes with '@' in their name or those acting as bus/container nodes (e.g., having multiple subnodes). This change improves clarity and maintainability by organizing non-address-mapped components at the top level, aligning with device tree best practices. This logic is applied only when generating Linux device trees (linux_dt=True). Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
Updates the overlay output file to use the `.dtso` extension (`pl.dtso`) instead of `.dtsi`. Conceptually, `.dtso` is the appropriate format for standalone Device Tree overlay sources, which are intended to be compiled into `.dtbo` binaries. In contrast, `.dtsi` files are meant to be included in `.dts` files and should not be compiled directly. This renaming aligns with upstream best practices and avoids confusion caused by the overloaded use of `pl.dtsi`. It also matches conventions already adopted in communities such as U-Boot and the Linux kernel. To ensure backward compatibility with existing workflows, the `pl.dtsi` file will also continue to be generated for a transitional period. It will be removed in a future release once downstream consumers have migrated to using `pl.dtso`. References: - U-Boot overlay documentation: https://docs.u-boot.org/en/latest/usage/fdt_overlays.html - Linux kernel overlay documentation: https://docs.kernel.org/devicetree/overlay-notes.html - Patch history and rationale: https://lore.kernel.org/all/20221024173434.32518-1-afd@ti.com/ Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Linux device tree, subnodes within the '/amba_pl' node that lack both 'reg' and 'ranges' properties are considered non-address-mapped.
To prevent device link failures, such subnodes are now relocated to the root node. This applies only to direct children of '/amba_pl' and excludes nodes with '@' in their name or those acting as bus/container nodes (e.g., having multiple subnodes).
This change improves clarity and maintainability by organizing non-address-mapped components at the top level, aligning with device tree best practices.
This logic is applied only when generating Linux device trees (linux_dt=True).