Conversation
zefir-git
left a comment
zefir-git
left a comment
There was a problem hiding this comment.
This pull request appears incomplete
…lasses until official database system is implemented
Co-authored-by: Zefir <contact@zefir.pro>
Co-authored-by: Zefir <contact@zefir.pro>
Co-authored-by: Zefir <contact@zefir.pro>
|
Extensive demo of the features that have been added |
|
Possible idea for you to add to the review @zefir-git We could have a Connector class, and that class will define whether the connector is an external (port) or internal connector. The class will have the type of connector (ex. thunderbolt) and the version as a number (ex. 4). This will also show what components can be removed and what types of components said connector supports. An internal example of this class would be storing a SATA III connector as an internal connector All these connectors will be stored as Connector[] in the Laptop class. It will also be useful for showing microSD and port selection on the future phone class I don't know how to form this exactly or what this class should have, so please give me some input |
| public readonly architecture: string; | ||
| public readonly graphics: string | null; | ||
| public readonly cores: CPU.Core[]; | ||
| // CPU Cache in kilobytes |
There was a problem hiding this comment.
you should put jsdoc like so on everything. We can later generate docs for the entire project from that
| // CPU Cache in kilobytes | |
| /** | |
| * CPU cache in KB | |
| */ |
3 participants
Add the necessary requirements to allow the creation of the API
Genesis Unveiled: Project Inception 🌌