Repository navigation
fix(droidplug): Resolve Adapter through LoaderContext in init - #495
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Contributor
|
If this ends up fixing my Galaxy issues on my other software, I owe you greatly. :) |
Author
|
Lmk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initlooked upAdapterwith plainFindClass, while every other class went throughLoaderContext. On a thread attached from native code, Android'sFindClasssearches only the system class loader (JNI tips), soinitfailed withClassNotFoundExceptionthere even when the thread's context class loader was the application's. Dioxus'smanganis(0.7.4 and later) gets theJavaVMfromndk_contextand attaches the calling thread itself (activity.rs).#311 hit the same system class loader failure for
FutureException.Adapternow resolves through the sameLoaderContext, which tries the context class loader beforeFindClass. The Android test app now callsinitfrom a thread it attaches itself, which covers this path in place of the Java-thread one, sinceinitruns once per process.On a Galaxy M52 (Android 13) and two Galaxy A35s (Android 14 and 15), the test app's setup fails with
failed to resolve Java class 'com/nonpolynomial/btleplug/android/impl/Adapter'before this change, andtestAdapterAddresspasses after it.