Resolving an issue with local_name being blank on Windows 11#269
Open
azimuthdeveloper wants to merge 1 commit intodeviceplug:masterfrom
Open
Resolving an issue with local_name being blank on Windows 11#269azimuthdeveloper wants to merge 1 commit intodeviceplug:masterfrom
azimuthdeveloper wants to merge 1 commit intodeviceplug:masterfrom
Conversation
Contributor
|
Ok, so, this is currently held up on a few different issues:
I'd really like to get this tested and confirmed first, because advertisement packets aren't required to have a local name field in BLE, only address. So it could be that advertisements are updating wrong elsewhere in the library anyways. Using FromBluetoothAddressAsync is going to pull from the system cache if that advertisement data isn't available, which could lead to other possible weirdness. |
|
Is there any progress in this pr? I have encountered the same problem in Windows 11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for this excellent BLE library!
On Windows 11, there is an issue with
local_namenot being populated at device scan time. This seems to be because Windows devices possibly do not observe thelocal_nameproperty in the advertisement packet.This PR resolves the issue by calling
BluetoothLEDevice::FromBluetoothAddressAsyncto specifically retrieve thelocal_namefor the device in question. In my testing, thelocal_nameproperty is now set 100% of the time at device discovery.However - the
BluetoothLEDevice::FromBluetoothAddressAsynccall is async while theupdate_propertiesfunction is sync. Because this call is also implemented on other platforms, I've decided to block on this call until it returns, so we don't have to make this function async, and then make all the other implementations async as well.Also, I started learning rust 2 weeks ago, so my code may be overly verbose, or this might just be a non-smart suggestion, so forgive any weirdness or lame ideas in the PR. Thanks for reviewing!