Skip to content

feature: make BATCH_CHUNK_LIMIT an env to increase it past 120 for larger deployments #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdxker merged 1 commit into from
Nov 21, 2024
Merged

feature: make BATCH_CHUNK_LIMIT an env to increase it past 120 for larger deployments #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ BM25_ACTIVE="true"
FIRECRAWL_URL=https://api.firecrawl.dev
FIRECRAWL_API_KEY=fc-abdef**************
PDF2MD_URL="http://localhost:8081"
BATCH_CHUNK_LIMIT=120
7 changes: 6 additions & 1 deletion server/src/handlers/chunk_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,12 @@ pub async fn create_chunk(
timer.add("get dataset count");
}

if chunks.len() > 120 {
let chunk_limit: usize = std::env::var("BATCH_CHUNK_LIMIT")
.unwrap_or("120".to_string())
.parse()
.unwrap_or(120);

if chunks.len() > chunk_limit {
return Err(ServiceError::PayloadTooLarge(
"Too many chunks provided in bulk. The limit is 120 chunks per bulk upload".to_string(),
)
Expand Down