Skip to content

add kaoto project #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

maximilianoPizarro
Copy link
Contributor

Description of Changes

added kaoto project

How to test? (OpenShift DevSpaces)

Open

From your Workspaces started, run the tasks from devfile, confirm the port to expose and open in browser:

image

optional: podman mode

Only run "tasks start-with-docker"

Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
@maximilianoPizarro maximilianoPizarro requested a review from a team as a code owner March 5, 2025 18:04
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 5, 2025 18:04
Copy link

openshift-ci bot commented Mar 5, 2025

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@michael-valdron
Copy link
Member

michael-valdron commented Mar 6, 2025

This has happened every time @maximilianoPizarro has opened a PR:

image

Being that @maximilianoPizarro is a stack owner, I'm thinking he should be added to devfile organization for this to pass, looking at the message given by the status check:

User maximilianoPizarro is not allowed to trigger CI via pull_request on this repo.

cc @thepetk @elsony

@maximilianoPizarro
Copy link
Contributor Author

This has happened every time @maximilianoPizarro has opened a PR:

image

Being that @maximilianoPizarro is a stack owner, I'm thinking he should be added to devfile organization for this to pass, looking at the message given by the status check:

User maximilianoPizarro is not allowed to trigger CI via pull_request on this repo.

cc @thepetk @elsony

@Jdubrick added me to Owners in the last PR from the other project.

Thanks in Advance again @michael-valdron and team.

@thepetk
Copy link
Contributor

thepetk commented Mar 9, 2025

This has happened every time @maximilianoPizarro has opened a PR:
image
Being that @maximilianoPizarro is a stack owner, I'm thinking he should be added to devfile organization for this to pass, looking at the message given by the status check:

User maximilianoPizarro is not allowed to trigger CI via pull_request on this repo.

cc @thepetk @elsony

@Jdubrick added me to Owners in the last PR from the other project.

Thanks in Advance again @michael-valdron and team.

This should be done for every new stack. So we should add this one here: https://github.com/devfile/registry/blob/main/.github/CODEOWNERS too.

@thepetk
Copy link
Contributor

thepetk commented Mar 9, 2025

This has happened every time @maximilianoPizarro has opened a PR:

image

Being that @maximilianoPizarro is a stack owner, I'm thinking he should be added to devfile organization for this to pass, looking at the message given by the status check:

User maximilianoPizarro is not allowed to trigger CI via pull_request on this repo.

cc @thepetk @elsony

+1 having in mind that now he will be an owner of two stacks.

Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs review from the @devfile/che-team too

Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the storybook command is failed on Che:
screenshot-github_com-2025_03_11-12_41_38

I suggest updating the command labels to follow a consistent format and arranging them in a logical order. This will improve clarity and make it easier to understand the execution steps.
To have something like:
screenshot-github_com-2025_03_11-12_55_14
instead of
screenshot-nimbusweb_me-2025_03_11-12_49_10

Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maximilianoPizarro
Copy link
Contributor Author

/retest-required

@maximilianoPizarro
Copy link
Contributor Author

Hi Team, any status about this?

@thepetk @elsony @Jdubrick

Thanks in advanced

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@Jdubrick
Copy link
Contributor

/ok-to-test

@thepetk
Copy link
Contributor

thepetk commented Apr 15, 2025

@maximilianoPizarro this is currently blocked by devfile/api#1702. I've already created a PR to address the issue so I'd say it will be unblocked soon.

@thepetk
Copy link
Contributor

thepetk commented Apr 25, 2025

@maximilianoPizarro needs to be rebased to the latest main

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general lgtm, I'll aprove once all checks are passing

/ok-to-test

@maximilianoPizarro
Copy link
Contributor Author

In general lgtm, I'll aprove once all checks are passing

/ok-to-test

Excellent, thank you for everything. Have a nice weekend 🙌

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 28, 2025
Copy link

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilianoPizarro, svor, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maximilianoPizarro
Copy link
Contributor Author

Hi @Jdubrick , I just wanted to ask if the pending status on Kunflux is in any way related to the progress of the PR, or if I should simply wait for the remaining reviewers to take a look. Have a great week. Thanks in advance!

@Jdubrick
Copy link
Contributor

Jdubrick commented Jun 2, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants