Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jhipster-online project #480

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

maximilianoPizarro
Copy link

@maximilianoPizarro maximilianoPizarro commented Sep 10, 2024

Description of Changes

Add jhipster-online devfile.yaml and Dockerfile image from quay.io/devfile/universal-developer-image with jhipster-generator 8.1.0.

How To Test

Works in Developer Sandbox

JHipster Online on Red Hat OpenShift Dev Spaces

java nodejs Angular Spring Redhat kubernetes Docker shell linkedin

Install JHipster Online on OpenShift Dev Spaces

  1. Login with your Red Hat Account. https://console.redhat.com/openshift/sandbox. Select "OpenShift Dev Spaces".

  1. Complete Git Repo URL parameter with the repo URL: https://github.com/maximilianoPizarro/jhipster-online

  1. Run Tasks from devfile in your Red Hat DevSpaces.

Taking a look at the Video Demo

JHipster Online on Red Hat Developer Sandbox

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maximilianoPizarro
Once this PR has been reviewed and has the lgtm label, please assign jdubrick for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Sep 10, 2024

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?

Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron

stacks/jhipster-online/2.33.0/devfile.yaml Outdated Show resolved Hide resolved
stacks/jhipster-online/2.33.0/docker/Dockerfile Outdated Show resolved Hide resolved
@Jdubrick
Copy link
Contributor

/ok-to-test

@maximilianoPizarro
Copy link
Author

Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?

Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron

Hi Team,

Absolutely yes! Add me owner from this solution.

Thanks in advance!

@maximilianoPizarro
Copy link
Author

/retest

@maximilianoPizarro
Copy link
Author

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments :)

stacks/jhipster-online/2.33.0/devfile.yaml Outdated Show resolved Hide resolved
stacks/jhipster-online/2.33.0/docker/Dockerfile Outdated Show resolved Hide resolved
stacks/jhipster-online/2.33.0/devfile.yaml Outdated Show resolved Hide resolved
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
@maximilianoPizarro
Copy link
Author

/retest

@maximilianoPizarro
Copy link
Author

Hi Team!

The last week I was recording a video about this integration. You see the video on my Youtube Channel or click on this image.

JHipster Online on Red Hat Developer Sandbox

The JHipster community supports the initiative published in this Linkedin post on my profile.

I remain attentive to any concerns.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get this imported in devspaces and everything seems to be working as intended, when trying to test with odo I ran into an issue with the mysql but that may have been my initial setup.

At this point in time I believe we are just waiting on time for our team to have a discussion around how to handle giving you ownership over this stack, correct me if I am wrong @thepetk @michael-valdron . After that discussion I think we can proceed with finalizing the PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants