Skip to content

fix(wait-for-konflux): add allowed-conclusions to include 'neutral' state#372

Merged
michael-valdron merged 1 commit into
devfile:mainfrom
michael-valdron:fix/wait-for-konflux-4
Jul 16, 2026
Merged

fix(wait-for-konflux): add allowed-conclusions to include 'neutral' state#372
michael-valdron merged 1 commit into
devfile:mainfrom
michael-valdron:fix/wait-for-konflux-4

Conversation

@michael-valdron

@michael-valdron michael-valdron commented Jul 15, 2026

Copy link
Copy Markdown
Member

Description of Changes

Fixes currently failing konfluxECWait job when leading up to staging promotion dispatch to restore promotion triggers when changes are introduced to registry-support modules.

Related Issue(s)

fixes devfile/api#1772

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Summary by CodeRabbit

  • Bug Fixes
    • Improved automated workflow handling by allowing successful, skipped, or neutral check results to proceed without unnecessary delays.

… conclusion to the wait job

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
michael-valdron requested a review from a team July 15, 2026 21:40
@openshift-ci
openshift-ci Bot requested review from Jdubrick and thepetk July 15, 2026 21:41
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98148444-b8ad-4587-9f6e-740151012321

📥 Commits

Reviewing files that changed from the base of the PR and between db79d18 and b518810.

📒 Files selected for processing (1)
  • .github/workflows/pushimage-next.yaml

📝 Walkthrough

Walkthrough

The next-image GitHub Actions workflow now treats success, skipped, and neutral Konflux check conclusions as acceptable in its wait-on-check step.

Changes

CI workflow update

Layer / File(s) Summary
Configure accepted check conclusions
.github/workflows/pushimage-next.yaml
The Konflux wait-on-check step allows success, skipped, and neutral outcomes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: jdubrick

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the core change: allowing neutral conclusions in the Konflux wait step.
Linked Issues check ✅ Passed The change addresses #1772's main requirement by allowing the neutral check conclusion in the next image workflow.
Out of Scope Changes check ✅ Passed The only code change is directly aligned with the linked issue and PR objective, with no unrelated edits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
michael-valdron merged commit f6034af into devfile:main Jul 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix registry-support next image workflow

2 participants