Add ingressClass CRD field

[thepetk]

Please specify the area for this PR

This PR adds support for the CRD field of the ingress class in the registry-operator.

What does does this PR do / why we need it:

fixes devfile/api#1434

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[thepetk]

@michael-valdron two qq:

1. We shouldn't set a default value I guess as in case of absence this value must be null right?
2. Should we also include the ingressClass value in the reconcileand theensure` functions?

[michael-valdron]

@michael-valdron two qq:

1. We shouldn't set a default value I guess as in case of absence this value must be null right?

Should match helm chart's default value (nginx): https://github.com/devfile/registry-support/blob/dd51121eae680cd52c72733ef1594719fd6e75f2/deploy/chart/devfile-registry/values.yaml#L18

2. Should we also include the ingressClass value in the reconcileand theensure` functions?

Not yet, this is to be done in devfile/api#1435. devfile/api#1434 is just covers the CRD, could also do accessor functions under defaults.go too to match your other PRs.

cc: @thepetk

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.23%. Comparing base (a9f14a4) to head (821b9ad).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   27.10%   26.23%   -0.87%     
==========================================
  Files          25       25              
  Lines        1428     1433       +5     
==========================================
- Hits          387      376      -11     
- Misses       1020     1032      +12     
- Partials       21       25       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-valdron]

I think similar changes to defaults.go under #76 should be done here as well.

[thepetk]

I think similar changes to defaults.go under #76 should be done here as well.

Done!

[thepetk]

@michael-valdron I feel the code coverage check could be skipped as is only -0,87% and I think the PR covers all test cases needed. WDYT?

[michael-valdron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michael-valdron]

@michael-valdron I feel the code coverage check could be skipped as is only -0,87% and I think the PR covers all test cases needed. WDYT?

@thepetk Yeah I think your test coverage is sufficient here.