-
Notifications
You must be signed in to change notification settings - Fork 23
Update to Go 1.22 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to Go 1.22 #105
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
openshift/release#65528 is blocking the integration testing from passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment for just for my knowledge but looks good to me
Question - I know the issue is to upgrade to 1.22 but should we consider going higher? Since Go supports the last 2 releases I believe we will rapidly run out of support on 1.22, wdyt?
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@Jdubrick To my knowledge when I created this issue 1.22 was the highest the latest operator sdk supports, however I do have devfile/api#1696 open as well to bump it to 1.24 as soon as its compatible. |
@Jdubrick We could do devfile/api#1696 after devfile/api#1693 is completed to see if 1.24 can still be used with all the upcoming sdk changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after tests pass, if we have issues open for 1.24 then I think all is okay
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description of Changes
Bumps Go version to 1.22 to patch runtime and support upcoming compatibility changes.
Related Issue(s)
resolves devfile/api#1694
Acceptance Criteria
Tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Running Unit Tests
Running Integration Tests
Notes To Reviewer
Any notes you would like to include for the reviewer.