Skip to content

Update to Go 1.22 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented May 30, 2025

Description of Changes

Bumps Go version to 1.22 to patch runtime and support upcoming compatibility changes.

Related Issue(s)

resolves devfile/api#1694

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Running Unit Tests

Running Integration Tests

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk May 30, 2025 16:18
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

openshift/release#65528 is blocking the integration testing from passing.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment for just for my knowledge but looks good to me

Question - I know the issue is to upgrade to 1.22 but should we consider going higher? Since Go supports the last 2 releases I believe we will rapidly run out of support on 1.22, wdyt?

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

Question - I know the issue is to upgrade to 1.22 but should we consider going higher? Since Go supports the last 2 releases I believe we will rapidly run out of support on 1.22, wdyt?

@Jdubrick To my knowledge when I created this issue 1.22 was the highest the latest operator sdk supports, however I do have devfile/api#1696 open as well to bump it to 1.24 as soon as its compatible.

@michael-valdron
Copy link
Member Author

@Jdubrick We could do devfile/api#1696 after devfile/api#1693 is completed to see if 1.24 can still be used with all the upcoming sdk changes.

@michael-valdron michael-valdron requested a review from Jdubrick May 30, 2025 19:34
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after tests pass, if we have issues open for 1.24 then I think all is okay

Copy link

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 30, 2025

@michael-valdron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.15-registry-operator-integration-test 6391530 link true /test v4.15-registry-operator-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devfile Registry Operator should be updated to support Go 1.22
2 participants