Skip to content

Conversation

@michael-valdron
Copy link
Member

What does this PR do?:

Updates references to the Go runtime in the documentation to refer to Go 1.21, added in #212.

Which issue(s) this PR fixes:

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron requested a review from a team June 12, 2024 20:03
@openshift-ci openshift-ci bot requested review from elsony and thepetk June 12, 2024 20:04
@michael-valdron
Copy link
Member Author

Client Impact

N/A

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 6a00bfa into devfile:main Jun 12, 2024
Jdubrick added a commit that referenced this pull request Aug 15, 2024
* update schema version to 2.2.2 for nodejs test child devfiles (#213)

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* add ubuntu server bypass error case for invalid registry urls (#217)

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Fix parent version on test devfile (#216)

* Fix parent version on test devfile

Signed-off-by: thepetk <thepetk@gmail.com>

* Update parent version

Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>

* bump k8s api (#212)

Signed-off-by: Kartikey-star <kmamgain@redhat.com>

* update references to Go 1.21 in docs (#218)

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Add support for 2.3.0 schema version (#219)

* updateApi.sh script includes newer schema versions

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* devfile 2.3.0 support

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* revert schema versions for testing older features

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Bump github.com/docker/docker (#221)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.1+incompatible to 25.0.6+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v25.0.1...v25.0.6)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update readme for 2.3.0 schema (#222)

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: Kartikey-star <kmamgain@redhat.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Co-authored-by: Michael Valdron <mvaldron@redhat.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Co-authored-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants