-
Notifications
You must be signed in to change notification settings - Fork 67
doc: Add documentation for backup feature #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9ba5af5 to
0a800dc
Compare
The DevWorkspaceOperatorConfig was extended to enable the workspace backup process. This commits describes the feature and how to configure it. Signed-off-by: Ales Raszka <araszka@redhat.com>
|
@Allda: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| The value provided for registry.path is only the first segment of the final location. The full registry path is assembled dynamically, incorporating the name of the workspace and the :latest tag, following this pattern: | ||
| `<registry.path>/<devworkspace-name>:latest` | ||
|
|
||
| - **`registry.authSecret`**: (Optional) The name of the Kubernetes Secret containing credentials to access the OCI registry. If not provided, it is assumed that the registry is public or uses integrated OpenShift registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth cross-linking with https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/registry/registry-overview
|
|
||
| There are several configuration options to customize the logic: | ||
|
|
||
| ### Integrated OpenShift container registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Integrated OpenShift container registry | |
| ### Integrated OpenShift container registry |
Actually, disregard my previous comment, since it looks like this is an official naming - https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/registry/registry-overview#openshift-registry-common-terms_registry-overview
|
|
||
| **Note:** The `path` field must contain the URL to your OpenShift integrated registry given by the cluster. | ||
|
|
||
| Once the backup job is finished the backup archives will be available in the DevWorkspace namespace under a repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Once the backup job is finished the backup archives will be available in the DevWorkspace namespace under a repository | |
| Once the backup job is finished, the backup archives will be available in the DevWorkspace namespace under a repository |
| with matching Devworkspace name. | ||
|
|
||
| ### Regular OCI compatible registry | ||
| To use a regular OCI compatible registry for backups, you need to provide registry credentials. Depending on your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To use a regular OCI compatible registry for backups, you need to provide registry credentials. Depending on your | |
| To use a regular OCI-compatible registry for backups, you need to provide registry credentials. Depending on your |
| Once the backup job is finished the backup archives will be available in the DevWorkspace namespace under a repository | ||
| with matching Devworkspace name. | ||
|
|
||
| ### Regular OCI compatible registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Regular OCI compatible registry | |
| ### Regular OCI-compatible registry |
|
|
||
| ### Regular OCI compatible registry | ||
| To use a regular OCI compatible registry for backups, you need to provide registry credentials. Depending on your | ||
| RBAC policy the token can be provided via a secret in the operator namespace or in each DevWorkspace namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| RBAC policy the token can be provided via a secret in the operator namespace or in each DevWorkspace namespace. | |
| RBAC policy, the token can be provided via a secret in the operator namespace or in each DevWorkspace namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great read, added a few minor suggestions
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Allda, ibuziuk, rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| **Note:** The `path` field must contain the URL to your OpenShift integrated registry given by the cluster. | ||
|
|
||
| Once the backup job is finished the backup archives will be available in the DevWorkspace namespace under a repository | ||
| with matching Devworkspace name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with matching Devworkspace name. | |
| with a matching Devworkspace name. |
|
|
||
| ```yaml | ||
| kind: DevWorkspaceOperatorConfig | ||
| apiVersion: controller.devfile.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| apiVersion: controller.devfile.io/v1alpha1 | |
| apiVersion: controller.devfile.io/v1alpha1 | |
| metadata: | |
| name: devworkspace-operator-config | |
| namespace: $OPERATOR_INSTALL_NAMESPACE |
| schedule: '0 */4 * * *' | ||
| imagePullPolicy: Always | ||
| ``` | ||
| The `authSecret` must point to real Kubernetes Secret of type `kubernetes.io/dockerconfigjson` containing credentials to access the registry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The `authSecret` must point to real Kubernetes Secret of type `kubernetes.io/dockerconfigjson` containing credentials to access the registry. | |
| The `authSecret` must point to a real Kubernetes Secret of type `kubernetes.io/dockerconfigjson` containing credentials to access the registry. |
dkwon17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of comments on my side
|
|
||
| ```yaml | ||
| apiVersion: controller.devfile.io/v1alpha1 | ||
| kind: DevWorkspaceOperatorConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| kind: DevWorkspaceOperatorConfig | |
| kind: DevWorkspaceOperatorConfig | |
| metadata: | |
| name: devworkspace-operator-config | |
| namespace: $OPERATOR_INSTALL_NAMESPACE |
The DevWorkspaceOperatorConfig was extended to enable the workspace backup process. This commits describes the feature and how to configure it.
What does this PR do?
What issues does this PR fix or reference?
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che