Skip to content

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 27, 2025

What does this PR do?

This PR adds a user entry with UID 1234 to the /etc/passwd file in the project-clone container image, ensuring that when the project-clone container runs on Kubernetes with the default security context, the user exists in the system's user database

RunAsUser: pointer.Int64(1234),

What issues does this PR fix or reference?

eclipse-che/che#23660

Is it tested? How?

  1. Deploy Che on minikube
  2. Add ssh keys and start a workspace from git ssh url, check that project failed to clone
  3. Build image and update DWO deployment env var to set a new project clone image
  4. Start a workpace, check that project cloned successfully.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha tolusha marked this pull request as ready for review November 28, 2025 09:16
&& echo "Installed Packages" \
&& rpm -qa | sort -V \
&& echo "End Of Installed Packages" \
&& echo "user:x:1234:0::/:/bin/sh" > /etc/passwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have minor question, we’re now overwriting /etc/passwd with a single entry. Are we okay with replacing the file entirely? Just want to make sure there isn’t any other content the base image depends on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
Oh, It must be >>

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, tolusha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit 1a8a0e8 into main Nov 29, 2025
11 checks passed
@dkwon17 dkwon17 deleted the 23660 branch November 29, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants