chore (deps) : Update controller-runtime to v0.18.7 #1712
Conversation
rohanKanojia
force-pushed
the
pr/bump-controller-runtime
branch
2 times, most recently
from
0c156fd to
cd53b6e
Compare
There was a problem hiding this comment.
@rohanKanojia Update this line to the following:
-go-version: 1.21
+go-version-file: go.mod
|
@michael-valdron : There is another Line 3 in cd53b6e |
rohanKanojia
force-pushed
the
pr/bump-controller-runtime
branch
4 times, most recently
from
dc06a2c to
8095621
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| module github.com/devfile/api/v2 | |||
|
|
|||
| go 1.21 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
Nit: Can we drop the patch number since AFAIK go just drops that anyway?
There was a problem hiding this comment.
When I dropped patch version, CI started failing with this error:
diff --git a/go.mod b/go.mod
index adb43d0..eb84ba0 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,8 @@
module github.com/devfile/api/v2
-go 1.22
+go 1.22.0
+
+toolchain go1.22.12
require (
github.com/ghodss/yaml v1.0.0
Go mod is not clean. Execute "go mod tidy && go mod vendor" locally and commit changes to fix an issue
When I run go mod tidy && go mod vendor locally, it automatically applies patch version. Shall I revert to patch version?
There was a problem hiding this comment.
Weird, if it's applying it then I'm okay ignoring the patch version being there. Was just a visual nit anyway and won't affect anything
There was a problem hiding this comment.
Weird, if it's applying it then I'm okay ignoring the patch version being there. Was just a visual nit anyway and won't affect anything
There was a problem hiding this comment.
Okay, thanks. I'm updating it to previous version.
rohanKanojia
force-pushed
the
pr/bump-controller-runtime
branch
from
8095621 to
347e42d
Compare
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/bump-controller-runtime
branch
from
347e42d to
3d433ed
Compare
@rohanKanojia Yes this will need to be bumped too, I see you've included this in your changes 👍 |
There was a problem hiding this comment.
/lgtm
@devfile/devfile-services-team does not have access to security/snyk (Devfile) so I think this is okay to merge.
Should get @devfile/che-team signoff before we merge.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michael-valdron, rohanKanojia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
The project is using quite an old version of
controller-runtimedependency.Update
sigs.k8s.io/controller-runtimedependency tov0.18.7. This dependency bump might have changed dependency of some other components too.Related Issue(s)
I was testing some change related to https://issues.redhat.com/browse/CRW-8603 in DevWorkspace operator
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
New testing and documentation issues can be opened under
devfile/api/issues.You can check the respective criteria below if either of the following is true:
If criteria is left unchecked please provide an explanation why.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Tests Performed
I just verified that schemaTest and apiTest are passing locally
How To Test
This is just a version bump, I just verified that schemaTest and apiTest are passing locally
Notes To Reviewer
While trying to use latest version of devfile in DevWorkspace operator, I was bumping into this issue kubernetes/client-go#1245 (comment) (it advises to bump version of controller-runtime in order to update to client go 0.27.0)