Skip to content

make sure to return empty content for 204 #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024
Merged

make sure to return empty content for 204 #808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2c2dc1
make sure to return empty content for 204
vincentsarago Apr 12, 2024
ffb78c4
Merge branch 'main' of https://github.com/developmentseed/titiler int…
vincentsarago Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/titiler/core/titiler/core/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
)
from starlette import status
from starlette.requests import Request
from starlette.responses import JSONResponse
from starlette.responses import JSONResponse, Response


class TilerError(Exception):
Expand Down Expand Up @@ -52,6 +52,9 @@ def exception_handler_factory(status_code: int) -> Callable:
"""

def handler(request: Request, exc: Exception):
if status_code == status.HTTP_204_NO_CONTENT:
return Response(content=None, status_code=204)

return JSONResponse(content={"detail": str(exc)}, status_code=status_code)

return handler
Expand Down