Skip to content

Adding extra="ignore" option to fix pydantic_settings.SettingsConfigDict issue with environement variables #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Adding extra="ignore" option to fix pydantic_settings.SettingsConfigDict issue with environement variables #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fad6d44
Adding extra ignore option in model_config pydantic-settings
imanshafiei540 Mar 20, 2024
4c2c6f2
lint
vincentsarago Mar 21, 2024
e2503bf
update changelog
vincentsarago Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release Notes

## 0.17.3 (2024-03-21)

### titiler.application

* Add `extra="ignore"` option `ApiSettings` to fix pydantic issue when using `.env` file (author @imanshafiei540, https://github.com/developmentseed/titiler/pull/800)

## 0.17.2 (2024-03-15)

### titiler.core
Expand Down
4 changes: 3 additions & 1 deletion src/titiler/application/titiler/application/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ class ApiSettings(BaseSettings):
# an API key required to access any endpoint, passed via the ?access_token= query parameter
global_access_token: Optional[str] = None

model_config = SettingsConfigDict(env_prefix="TITILER_API_", env_file=".env")
model_config = SettingsConfigDict(
env_prefix="TITILER_API_", env_file=".env", extra="ignore"
)

@field_validator("cors_origins")
def parse_cors_origin(cls, v):
Expand Down