Skip to content

Use React legacy API to fix react-helmet #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
+4 −4
Merged

Use React legacy API to fix react-helmet #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67931e3
Use React legacy API
vgeorge Jun 9, 2022
ab708c2
Use more generic explanation on why React legacy API is used
vgeorge Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect } from 'react';
import { createRoot } from 'react-dom/client';
import { render } from 'react-dom';

// Root component.
function Root() {
Expand All @@ -13,6 +13,7 @@ function Root() {
return <p>Hello from Starter</p>;
}

const container = document.getElementById('app-container');
const root = createRoot(container);
root.render(<Root />);
// React legacy API is used because react-helmet is not compatible with the
// new one introduced in React v18. See:
// https://github.com/nfl/react-helmet/issues/669#issuecomment-1134228545
render(<Root />, document.querySelector('#app-container'));