Upgrade React and minor dependecies #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfdsilva
requested changes
Jun 3, 2022
Member
danielfdsilva
left a comment
danielfdsilva
left a comment
There was a problem hiding this comment.
Since this is being upgraded to use react 18 it would be good to update how react renders in main.js to take advantage of the new apis.
Member
Author
|
@danielfdsilva thanks for catching this, can you please do another review? |
danielfdsilva
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades:
To fix security warnings, I removed yarn.lock and re-installed everything. Now the only warning (from
yarn audit) is from gulp, but I wasn't sure if it is possible to upgrade from the legacy version without updating the gulpfile. Another module we could upgrade is stylelint, but it didn't look straigthforward to include in this PR. A migration guide is available hereThis is ready for review.
cc @danielfdsilva