Skip to content

Display organization badges on Team page #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 17, 2023
Merged

Display organization badges on Team page #415

merged 39 commits into from
Mar 17, 2023

Conversation

kamicut
Copy link
Member

@kamicut kamicut commented Mar 7, 2023 •
edited
Loading

  • Create new method for getTeamMembers that includes badges code optionally
  • The fields parameter will allow us to select the extended “badge” field to be propagated down to the table
  • Add badges to the model when we see team members to see a team member’s individual badges (when this team is an org team)
  • Make sure permissions are correct for new method for teams members
  • Create a column called “badge” in the table view that can display the badges

@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osm-teams ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 2:53AM (UTC)

@kamicut kamicut changed the title move badge client code to separate file Display badges on Team page Mar 7, 2023
@kamicut kamicut changed the title Display badges on Team page Display organization badges on Team page Mar 7, 2023
@kamicut kamicut marked this pull request as draft March 7, 2023 14:30
@kamicut
Merge remote-tracking branch 'origin/feature/team-badge-column' into …
d62a82a 
…feature/team-badge-column

>>>>>>> 407b704 (move badge client code to separate file)
@kamicut kamicut marked this pull request as ready for review March 9, 2023 17:06
@kamicut kamicut mentioned this pull request Mar 9, 2023
Open
@LanesGood LanesGood mentioned this pull request Mar 16, 2023
Closed
@LanesGood
Copy link
Member

@kamicut #420 now includes styling on the username for profile click and styled menubutton. I'll wait until that's merged in to do any additional style updates for the actions menu and/or profile.

@LanesGood LanesGood self-requested a review March 17, 2023 03:04
LanesGood
LanesGood approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@LanesGood LanesGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🦡

@LanesGood LanesGood mentioned this pull request Mar 17, 2023
Open
@kamicut kamicut merged commit 1afc278 into develop Mar 17, 2023
@kamicut kamicut deleted the feature/team-badge-column branch March 17, 2023 16:42
This was referenced Mar 17, 2023
Closed
Closed
This was referenced May 1, 2023
Closed
Closed
@LanesGood LanesGood mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LanesGood LanesGood LanesGood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign org badges to a user on org team page Badges should be displayed next to usernames
2 participants
@kamicut @LanesGood