Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observe logo header in nav drawer #315

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Conversation

LanesGood
Copy link
Member

The Observe logo and text in the navigation drawer are missing. Where did the logo go??

This PR:

Current edit-ways branch:
Observe_menu

@LanesGood
Copy link
Member Author

@geohacker at one point the Observe Logo showed up in the drawer - now it does not. It looks like it was previously stored in the iconfont, or at least wound up in Android folders and iOS ones. This may require adding the SVG to the repo, then re-running the font generation and reuploading again to the /observe-icon-font repo :(

I can investigate further tomorrow if needed.

@geohacker
Copy link
Member

Oh nice catch @LanesGood. I think this logo was an image asset pulled in with the Image styled component via a URI. We may have blown this away during our updates to icons. Adding this back to the assets folder should do the trick I think.

@geohacker
Copy link
Member

@LanesGood I just added the icons back. This was getting blown away because of our update-icons.sh script and we should figure out a way to manage that properly, I'll ticket that separately.

@geohacker geohacker marked this pull request as ready for review June 9, 2020 16:54
@sethvincent sethvincent merged commit 304c2dc into edit-ways Jun 9, 2020
@sethvincent sethvincent deleted the fix/logo-drawer branch June 9, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants