fix: Restore DataFilterExtension functionality with vectorized accessor input #977
+21
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATL2001
approved these changes
Oct 26, 2025
Collaborator
ATL2001
left a comment
ATL2001
left a comment
There was a problem hiding this comment.
YES👏 I didn't pull this branch down but I did a copy/paste to get the relevant parts into my branch (which I'll discard so as to not cause commit issues) and it's all working again!
I figured it must have had something to do with the switch from the arrow table to the recordbatches, and now that I see what you're doing here, it makes a lot of sense why I wasn't able to find anywhere in deckgl-layers to do something like this.
kylebarron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code was no longer working after #912 because we're passing Arrow
Vectors into the accessor props instead ofarrow.Dataobjects.This PR fixes that by selecting a specific record batch of data to pass into each layer.
In geoarrow/deck.gl-layers#164 upstream, it should be easier to catch errors like this.
Closes #955