feat(surface): Implement from_rasterio with simple corner reprojection
#976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
added a commit
that referenced
this pull request
Oct 28, 2025
### Change list - Currently, as implemented in #976 the SurfaceLayer only supports four vertices and two internal triangles. Over larger areas this will run the risk of larger reprojection non-linearities. - This PR implements a quick initial hack to this problem: offering the user the ability to specify the height and width of the regular grid they'd like to use. ```py import rasterio from sidecar import Sidecar from lonboard import Map from lonboard.experimental._surface import SurfaceLayer # aws s3 cp s3://naip-visualization/ny/2022/60cm/rgb/40073/m_4007307_sw_18_060_20220803.tif ./ --request-payer src = rasterio.open("m_4007307_sw_18_060_20220803.tif") layer = SurfaceLayer.from_rasterio( src, downscale=4, opacity=0.8, wireframe=True ) sidecar = Sidecar(anchor="split-right") m = Map(layer) with sidecar: display(m) ``` <img width="588" height="618" alt="image" src="https://github.com/user-attachments/assets/45943649-4669-4bef-8879-eacc4598a054" /> <img width="468" height="581" alt="image" src="https://github.com/user-attachments/assets/e5dd64e4-6c59-4592-a0df-07ff90fc8f96" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-24.at.5.17.02.PM.mov
If we look at the wireframe we see it's only two triangles:
