Add type hinting for constructors and from_geopandas
#399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note to self, I wanted to do this with generics, so that I didn't have to add the two functions to each subclass, but that appears not to work: microsoft/pyright#5574 |
roger120981
pushed a commit
to roger120981/lonboard
that referenced
this pull request
Jul 14, 2025
…ed#399) Better type hinting in vscode! This should hopefully be a massive QOL upgrade, at least in vscode. This doesn't show up in Jupyter though 🤷♂️  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better type hinting in vscode! This should hopefully be a massive QOL upgrade, at least in vscode. This doesn't show up in Jupyter though 🤷♂️