Support multiple layers on a single map #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
changed the title
kylebarron
commented
Oct 30, 2023
| "react-map-gl": "^7.1.5" | ||
| }, | ||
| "devDependencies": { | ||
| "@jupyter-widgets/base": "^6.0.6", |
There was a problem hiding this comment.
This is a type-only dependency, so I think it's ok to have it as a dev dependency. And probably better this way, as it won't interact with whatever version jupyterlab is using.
kylebarron
commented
Oct 30, 2023
Comment on lines
+48
to
+50
| let [subModelState, setSubModelState] = useState< | ||
| Record<string, BaseGeoArrowModel> | ||
| >({}); |
There was a problem hiding this comment.
This manually stores the state of all child layers
|
This is working now! Works like a charm in colab too (I published an 0.2.0-alpha.1 to make it easier to test): |
|
@vgeorge I think this is ready to merge if you'd like to take a look at it! Any feedback is appreciated! It looks like it works, but maybe there's a cleaner way to implement it 🤷♂️ |
|
Merging now to make follow up prs off the main branch, but feedback still welcome |
roger120981
pushed a commit
to roger120981/lonboard
that referenced
this pull request
Jul 14, 2025
* attempt async use effect * scratch work * wip * simplify js model * flesh out model * Clean up model state transfer * Remove existing callbacks * Add initial view state to Map * separate function for sub model state * remove empty file * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
WidgetManager.get_model(). In this PR's implementation, it manages asubModelStateobject that contains a mapping from layer id to model data. Each model data now has a class (likeScatterplotModel) that wraps each layer model with strong typing and which also manages instantiating event handlers to update the map when the model data changes.todo:
Follow ups for future prs:
__repr__to make the repr of a layer pass its data intoMap()? Thus making it easy to render just one layer, but directing people to create aMapdirectly for more control.initial_view_statefor the top-levelMapobject.tsxapps for specific layersCloses #33