Skip to content

changes to generalize get_bounds #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2020
Merged

changes to generalize get_bounds #170

merged 6 commits into from
Jun 2, 2020

Conversation

martham93
Copy link
Contributor

@martham93 martham93 commented May 29, 2020 •
edited
Loading

to address issue #169

cc @drewbo

@martham93 martham93 requested a review from drewbo May 29, 2020 22:11
drewbo
drewbo suggested changes May 30, 2020
View reviewed changes
Copy link
Contributor

@drewbo drewbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two small stylistic things; can you also add a new test for this?

@martham93 martham93 requested a review from drewbo June 1, 2020 23:28
@martham93
Copy link
Contributor Author

martham93 commented Jun 1, 2020 •
edited
Loading

thanks for the style suggestions, those should all be addressed now and I added a test.
I think the way I implemented the new test in a separate file that is pretty repetitive to what's in integration/test_classification_labels_geojson.py. I don't know if it would be better to add the test for the linestring geojson into the already existing polygon geojson test?

cc @drewbo

@martham93 martham93 merged commit 8f379ee into master Jun 2, 2020
@drewbo drewbo deleted the get_bounds_fix branch June 26, 2020 20:29
@drewbo drewbo mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo Awaiting requested review from drewbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martham93 @drewbo