Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested GeometryCollection with warnings. #111

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Add support for nested GeometryCollection with warnings. #111

merged 2 commits into from
Mar 14, 2023

Conversation

eseglem
Copy link
Collaborator

@eseglem eseglem commented Mar 14, 2023

Closes #110.

What I am changing

  • Added support for nested GeometryCollection (with warnings)
  • Tweaked some tests to not throw the warnings.

How I did it

  • Changed the type to a Union, and updated types / tests to match.

How you can test it

  • Updated tests.

Related Issues

@vincentsarago
Copy link
Member

🙏 thanks @eseglem

Once you update the changelog you can go ahead and merge 🙏

@eseglem eseglem merged commit 96eb472 into developmentseed:main Mar 14, 2023
@eseglem eseglem deleted the feature/allow-nested-geometrycollection branch July 5, 2023 14:47
@eseglem eseglem mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested GeometryCollection?
2 participants
@eseglem @vincentsarago