Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add has_z function to Geometries. #103

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Add has_z function to Geometries. #103

merged 2 commits into from
Feb 9, 2023

Conversation

eseglem
Copy link
Collaborator

@eseglem eseglem commented Feb 1, 2023

What I am changing

  • Add a has_z property to Geometries to simplify WKT and facilitate additional capabilities such as force_2d and force_3d in the future.

How I did it

  • Added helper functions to determine if any of the coordinates have a Z value
  • Used those functions for the property each geometry type
  • Removed individual _wkt_inset functions since we can reference .has_z

How you can test it

  • It was already being tested on some level some via WKT tests.
  • Added tests dedicated to the function, including weird mixed dimensionality cases not covered in WKT

Related Issues

@eseglem eseglem changed the title Add function to Geometries. Add has_z function to Geometries. Feb 1, 2023
@vincentsarago vincentsarago merged commit d6c291e into developmentseed:main Feb 9, 2023
@eseglem eseglem deleted the feature/add-has-z-function branch February 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatial-jeff geospatial-jeff geospatial-jeff approved these changes

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eseglem @vincentsarago @geospatial-jeff