Skip to content

Conversation

@bitner
Copy link
Contributor

@bitner bitner commented Mar 20, 2025

This PR adds further reductions in the case of and/or operations.

  • If there are any nested arguments that are of the same operator (and or or), move those arguments up into the higher and/or.
  • Remove duplicate expressions from the and/or arguments
  • Short circuit and if there are ANY false records for AND, return false.
  • Short circuit and if there are ANY true records for OR, return true.
  • If the arguments are reduced to a single expression, return just that expression.

@bitner bitner requested a review from alukach March 20, 2025 21:01
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll have time for a more throughough review next week, but just a quick nit check

bitner and others added 4 commits March 26, 2025 10:11
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@bitner bitner merged commit c848839 into main Mar 26, 2025
1 check passed
@bitner bitner deleted the reducedupeands branch March 26, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants