-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collecticons revamp π οΈ #21
Conversation
This is great! What's the difference between |
For example:
This gets very handy. But I think I can make some improvements to the react version to support some of the other props we have like the @ricardoduplos Btw, there are some icons like calendar-minus, or magnifying-glass-minus, that are not rendering correctly. I'd appreciate if you could have a look |
@danielfdsilva wow, nice! This looks like a lot of great cleanup work. To confirm, new icons are added directly as svg's to the I also see there are multiple readmes for the different packages. More of a question for @oliverroick or anyone who is using collecticons in frontend dev work; should all the readmes be combined into one? Also along the lines of Oliver's questions above; the readme for collecticons-react explicitly discusses using collecticons in chakra; this is confusing if we should instead be pushing developers to use collecticons-chakra for that purpose. |
2d66143
to
fd9f2bb
Compare
@LanesGood Added a line about the icons location and fixed the READMEs. I think we need different readme files for the different packages. You want to be able to see the docs for what you're using (even though right now they're very similar.) |
@ricardoduplos @LanesGood @oliverroick Anything else to look into, or is this good to move forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as an icon contributor. Thanks for the read me changes - really nice to see this all consolidated!
This PR brings a total revamp of collecticons. π
There were too many repositories related to collecticons and it was difficult to keep track of everything.
This is the current landscape:
developmentseed/collecticons
- This repo. Originally the source code for http://collecticons.iodevelopmentseed/collecticons-lib
- The collection icons in SVG formatdevelopmentseed/collecticons-processor
- The script that generates the font files from the SVG's.developmentseed/collecticons-chakra
- The SVG icons as react components for Chakra UI.Changes
The
collecticons-processor
is pretty outdated and we're not really using icon fonts anymore. This repo is going to be deprecated and archived.It doesn't make a lot of sense to keep a repo (
collecticons-lib
) specifically for the SVG icons. The icons will be moved, and the repo deprecated and archived.We now have a component library for Chakra UI, but nothing for React alone which is lacking.
The proposed new structure is to centralize the different packages under a monorepo managed by lerna and improve the build process. The SVG icons are stored under the
icons
folder and then usingyarn icons
we generate the react components for Chakra UI and React alone.These packages will then be published to npm as
@devseed-ui/collecticons-chakra
and@devseed-ui/collecticons-react
. See the Versioning section of the README for a more detailed flow.This repo also contains the showcase website for http://collecticons.io.
In this way we minimize the number of steps needed to create and contribute to the collecticons project. π
Before going ahead with these changes I would like to hear your thoughts about the new structure and if you have any suggestions or concerns.
@ricardoduplos @LanesGood as icons contributors
@oliverroick as another pair of developer eyes (given your contribution to the Chakra UI collecticons repo)
π¦