-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collecticons V4 #19
Merged
Merged
Collecticons V4 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roadmap to simplify collecticons-processor, replacing gulp and middleman plugins for font generation.
danielfdsilva
force-pushed
the
feature/v4
branch
19 times, most recently
from
January 29, 2019 11:57
4a1f902
to
c436417
Compare
danielfdsilva
force-pushed
the
feature/v4
branch
11 times, most recently
from
January 29, 2019 12:55
3bff2a0
to
7957ee8
Compare
danielfdsilva
force-pushed
the
feature/v4
branch
from
January 29, 2019 12:57
7957ee8
to
d2beed5
Compare
Fix #8 |
Include regression tests
vgeorge
requested changes
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing locally and I could generate a debug bundle successfully. Added some minor changes, mostly fixing typos.
Seems DEVELOPMENT.md isn't linked anywhere, I suggest to delete it as there are testing instructions at the README.
Co-Authored-By: danielfdsilva <daniel@developmentseed.org>
- Adds font to the catalog - Disables the style output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes below the fold
Collecticons Processor v4.0.0 was completely written from the ground up.
It doesn't rely on gulp and its plugins anymore, leveraging the font creation modules directly. This results in a smaller and simpler codebase, easier to maintain and test. Although the functionality is practically the same, some of the commands changed. See the migration guide below.
Changelog
grid
command as it is no longer needed with the new collecticons libraryttf
andeot
fontswoff2
font--no-placeholder
to--no-sass-placeholder
--no-standalone
to--no-css-class
_
. This will have to be explicitely set with--style-name _icons
, for example.--experimental-font-on-catalog
and--experimental-disable-styles
flags.Migration guide
Default behavior
The previous default behavior (
$ collecticons compile source/
) included theeot
,ttf
, andwoff
and did not embed the fonts.This can now be achieved with the following (with the exception of
eot
andttf
support which was dropped).Gulp
Since this new version of Collecticons Processor includes a programatic API, it is no longer required to use a child process when integrating with
gulp
.The above code can now be written as:
Experimental features
The flags
--experimental-font-on-catalog
and--experimental-disable-styles
were added as a first experiment to have collecticons work with styled-components. They are still being tested out and the API is likely to change. Use at your own risk