Fix for webpack 4 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to THE guy https://twitter.com/TheLarkInn/status/968286344794419200
Contributor
Author
|
Tested the change on my own project, seems to work! |
Contributor
Author
|
Hi @developit is there anything more I need to do to get this PR merged? |
developit
approved these changes
Feb 28, 2018
Owner
|
Nope, looks good to me! |
Contributor
Author
|
Thanks for merging! 🎉 Could we have a new release published please? |
|
Hi @developit. Any reason this is not released yet? |
Owner
|
nope! releasing now |
Owner
|
Released as 1.0.2 |
Contributor
Author
|
Thanks a lot!
…On Sat., 3 Mar. 2018, 13:29 Jason Miller, ***@***.***> wrote:
Released as 1.0.2
<https://github.com/developit/workerize-loader/releases/tag/1.0.2>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABRKNK1eWHpfPNoALOvJ6iSBdiWRN89Xks5tagAcgaJpZM4SULVB>
.
|
|
Yeah thanks for this, ❤️ this loader! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to THE guy https://twitter.com/TheLarkInn/status/968286344794419200
close #25