Skip to content

Update react.js to use forceUpdate as default#122

Closed
lucas-aragno wants to merge 1 commit intodevelopit:masterfrom
lucas-aragno:master
Closed

Update react.js to use forceUpdate as default#122
lucas-aragno wants to merge 1 commit intodevelopit:masterfrom
lucas-aragno:master

Conversation

@lucas-aragno
Copy link

Hey @developit I have run into cases that connected components wont work as expected (also seen this happening to a lot of ppl using react) I've found that the problem seems to be that it just doesn't get in to the first two forceUpdate I have added one more and seems to fix my problem (although idk if im updating by default) but for now seems to be solving my issue, just putting this out there. Let me know your thoughts

@developit
Copy link
Owner

developit commented Jan 4, 2019

Hi @lucas-aragno! I believe this is related to #120. The fix should be to hook componentWillReceiveProps.

@lucas-aragno
Copy link
Author

hey @developit ! its been a while I think we are using my fork for now but im not working on that project anymore so... I think you can close this PR if this isnt a relevant fix. I'll check out #120 ! thanks for the response :)

@developit developit closed this in a84fc5c Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants