Fixes for #97 and #103 react.d.ts needs to be updated#101
Merged
developit merged 2 commits intodevelopit:masterfrom Aug 29, 2018
namankheterpal:patch-1
Merged
Fixes for #97 and #103 react.d.ts needs to be updated#101developit merged 2 commits intodevelopit:masterfrom namankheterpal:patch-1
react.d.ts needs to be updated#101developit merged 2 commits intodevelopit:masterfrom
namankheterpal:patch-1
Conversation
As `React` is being imported as `import * as React from "react";` So `extends Component` will give reference error in Typescript. The correct way to refer is by `React.Component`
Fix! these changes will solve the issue #103. Current definition file is giving type mismatch error with stateful components. With this both `connect` decorator and function are working fine.
namankheterpal
changed the title
Component should be referred from Reactreact.d.ts needs to be updated
This was referenced Jul 18, 2018
developit
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
Reactis being imported asimport * as React from "react";Soextends Componentwill give reference error in Typescript. The correct way to refer is byReact.Component