Types for connect class based components#100
Closed
lukelindsey wants to merge 22 commits intodevelopit:masterfrom
Closed
Types for connect class based components#100lukelindsey wants to merge 22 commits intodevelopit:masterfrom
lukelindsey wants to merge 22 commits intodevelopit:masterfrom
Conversation
|
This might be a dupe of #102 (and vice versa?). |
Author
|
@kohlmannj I'd say you're right. The only difference is I have leveraged the existing typings from preact itself, so it's a little cleaner and easier to understand. Both solutions work for me. @namankheterpal do you agree about closing #102 or is there another difference that I'm missing? |
added 21 commits
August 12, 2018 17:40
I'm giving myself 8 more bytes to work with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where typescript won't allow connecting a class based component as the types were written only for SFC. Example error is below.
Argument of type 'typeof MyClassBasedComponent' is not assignable to parameter of type '(props: OwnProps & PropsFromStore) => VNode<any>'. Type 'typeof MyClassBasedComponent' provides no match for the signature '(props: OwnProps & PropsFromStore): VNode<any>'.