Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typescript issue with NodeNext, fix #166 #167

Merged
merged 1 commit into from
Oct 25, 2022
Merged

chore: fix typescript issue with NodeNext, fix #166 #167

merged 1 commit into from
Oct 25, 2022

Conversation

Mister-Hope
Copy link
Contributor

No description provided.

@lbm98
Copy link

lbm98 commented Aug 27, 2022

We might also need to lower the "typings" property as described in typescriptlang.org

diff --git a/node_modules/mitt/package.json b/node_modules/mitt/package.json
index ad38c7b..7649cc8 100644
--- a/node_modules/mitt/package.json
+++ b/node_modules/mitt/package.json
@@ -7,12 +7,13 @@
   "jsnext:main": "dist/mitt.mjs",
   "umd:main": "dist/mitt.umd.js",
   "source": "src/index.ts",
-  "typings": "index.d.ts",
   "exports": {
+    "types": "./index.d.ts",
     "import": "./dist/mitt.mjs",
     "require": "./dist/mitt.js",
     "default": "./dist/mitt.mjs"
   },
+  "typings": "index.d.ts",
   "scripts": {
     "test": "npm-run-all --silent typecheck lint mocha test-types",
     "mocha": "mocha test",

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Aug 28, 2022

I did not remove typings field? Why are you mentioning that?

Edited: You might want to express that we need a typings property in exports, but that's UNNEEDED, as long as typescript cares about exports field, it already recognize types

@Mister-Hope
Copy link
Contributor Author

Hi, any update with this?

@Mister-Hope
Copy link
Contributor Author

Mister-Hope commented Oct 18, 2022

Any update with this? @developit

@developit developit merged commit 1194efb into developit:main Oct 25, 2022
@developit
Copy link
Owner

Thanks! Sorry about the delay.

@Mister-Hope
Copy link
Contributor Author

Any release schedule for this?

@Mister-Hope
Copy link
Contributor Author

Hi bro, we still need this fix to be published as 3.0.1

@marcoreni
Copy link

hey @developit , is there a way to get this released?

@dgeibi
Copy link

dgeibi commented Jun 6, 2023

Hi @developit, we need v3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants