Feat/2020 day 07 #128
Merged
Feat/2020 day 07 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gold bag Solution for part 1
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 93.10% 93.45% +0.35%
==========================================
Files 30 32 +2
Lines 1044 1100 +56
==========================================
+ Hits 972 1028 +56
Misses 72 72
Continue to review full report at Codecov.
|
…ng debugging noise
solution for part 2
Solves part 2 Logic was overly complicated. Refactoring to pass the multiplier through each level made the recursion much simpler (multiplying can be done before returning to parent). Reduces code, and fixes the bug that was showing up in real data but not showing up with test data.
Owner
Author
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for part 1