Skip to content

Commit

Permalink
Change download_row_limit_bytes to download_limit_bytes (rilldata#5186)
Browse files Browse the repository at this point in the history
* Change download_row_limit_bytes to download_limit_bytes

* Fix local limit
begelundmuller authored Jul 3, 2024
1 parent 95ead30 commit f939307
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions cli/pkg/local/app.go
Original file line number Diff line number Diff line change
@@ -180,8 +180,8 @@ func NewApp(ctx context.Context, opts *AppOptions) (*App, error) {

// Merge opts.Variables with some local overrides of the defaults in runtime/drivers.InstanceConfig.
vars := map[string]string{
"rill.download_row_limit": "0", // 0 means unlimited
"rill.stage_changes": "false",
"rill.download_limit_bytes": "0", // 0 means unlimited
"rill.stage_changes": "false",
}
for k, v := range opts.Variables {
vars[k] = v
2 changes: 1 addition & 1 deletion runtime/drivers/registry.go
Original file line number Diff line number Diff line change
@@ -73,7 +73,7 @@ type Instance struct {
// InstanceConfig should only be used for config that the user is allowed to change dynamically at runtime.
type InstanceConfig struct {
// DownloadLimitBytes is the limit on size of exported file. If set to 0, there is no limit.
DownloadLimitBytes int64 `mapstructure:"rill.download_row_limit_bytes"`
DownloadLimitBytes int64 `mapstructure:"rill.download_limit_bytes"`
// InteractiveSQLRowLimit is the row limit for interactive SQL queries. It does not apply to exports of SQL queries. If set to 0, there is no limit.
InteractiveSQLRowLimit int64 `mapstructure:"rill.interactive_sql_row_limit"`
// StageChanges indicates whether to keep previously ingested tables for sources/models, and only override them if ingestion of a new table is successful.

0 comments on commit f939307

Please sign in to comment.