Complete implementation #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… processing Signed-off-by: Ritheesh Baradwaj <ritheeshbaradwaj@gmail.com>
Signed-off-by: Ritheesh Baradwaj <ritheeshbaradwaj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completes the Mimasa application by finishing the translation pipeline and implementing previously missing features.
src/translation/translation.pyto orchestrate audio extraction, run audio and video translations concurrently and merge the translated audio back into the processed video using ffmpeg._combine_audio_videohelper to handle audio/video muxing and fallback to copying when no audio is produced.src/translation/audio_translation.pyto separate vocals from music and return the path to the isolated vocals file. The translated audio path is now stored on the instance astranslated_audio_filefor downstream use.These changes allow the application to produce a final video with the updated audio track. The translation logic remains stubbed; future work can integrate speech-to-text, machine translation and text-to-speech synthesis.