fix: resolve wikilinks across all directories #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wikilinks like [[PageName]] typically reference files without full paths, expecting the link to resolve to any matching file regardless of its directory location. This is consistent with how tools like Obsidian and roamlinks handle wikilinks. Previously, wikilinks were only resolved relative to the current file's directory, which meant [[PageName]] in docs/subdir/file.md would only find docs/subdir/PageName.md, not docs/other/PageName.md. Now, wikilinks search all nodes by filename, while standard markdown links [text](path) continue to resolve relative to the current file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[[PageName]]now correctly resolve to any matchingPageName.mdin the projectProblem
Wikilinks (e.g.,
[[PageName]]) were only resolved relative to the current file's directory. This meant:[[MyPage]]indocs/blog/post.mdwould only finddocs/blog/MyPage.mddocs/pages/MyPage.mdeven though that's the intended targetThis is inconsistent with how Obsidian, mkdocs-roamlinks-plugin, and other wikilink tools work - they search the entire vault/project for matching filenames.
Solution
For wikilinks specifically, search all nodes by filename instead of resolving relative paths. Standard markdown links
[text](path)continue to resolve relative to the current file as before.Test plan