add

architectural_smells.csv

@@ -0,0 +1,14 @@
+"Primary Service / Module","Code File Path (if applicable)","Code Line(s)","Labeling"
+"bookstore-commons module","bookstore-commons/pom.xml","L25-L140","Shared Platform Library - the commons jar wires in validation, JPA, Web MVC, H2, test, Eureka, Consul, Hystrix, OpenFeign, OAuth2, JWT, Swagger, Lombok, and Dozer so every consumer inherits the full runtime stack even when it only needs a utility class, locking services to a monolithic dependency bundle."
+"bookstore-feign library","bookstore-feign/pom.xml","L23-L123","Shared Platform Library - the Feign helper adds Spring MVC, JPA, H2, tests, Eureka, Hystrix (twice), OpenFeign, OAuth2, Security, JWT, Swagger, and Lombok to expose a few client interfaces, forcing each service that wants one downstream client to accept the entire platform footprint."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/controller/OrderController.java","L30-L64","Unversioned API Surface - every REST endpoint (/order, /orders, /previewOrder) is rooted at the service base path without a version prefix, so any breaking change to payloads or semantics immediately breaks all consumers with no opt-in migration path."
+"bookstore-account-service","bookstore-account-service/src/main/java/com/devd/spring/bookstoreaccountservice/controller/UserController.java","L39-L99","Unversioned API Surface - administrative and self-service operations all live under /user, /users, and /userInfo without /v1 (or similar), preventing the team from versioning the endpoints independently for back-office and retail clients."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java","L63-L198","Unstable Dependency - order creation performs synchronous RPC calls to the billing and payment services for every checkout (billingFeignClient.getAddressById, paymentFeignClient.doPayment), so any latency spike or API change in those dependencies blocks or fails the transaction end-to-end."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java","L77-L198","Greedy Service - createOrder fetches addresses, assembles order aggregates, calculates taxes and shipping, triggers payment capture, persists billing and shipping snapshots, and clears the cart, concentrating multiple business capabilities inside one class instead of delegating to focused domain services."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java","L77-L156","Orchestrator Bottleneck - the order workflow choreographs each remote call (billing lookup, payment authorization) in sequence with no asynchronous handoff, retries, or circuit breaking beyond Hystrix defaults, making the order service a tight coupling point for the entire purchase saga."
+"bookstore-api-gateway-service","bookstore-api-gateway-service/src/main/resources/application.yml","L26-L42","Hub-like Gateway - Zuul centralises routing for billing, catalog, account, order, and payment domains under a single /api prefix, so a gateway outage or misconfiguration brings down every customer-facing capability."
+"bookstore-account-service & bookstore-order-service","bookstore-account-service/src/main/resources/application.yml; bookstore-order-service/src/main/resources/application.yml","Account:L60-L115; Order:L68-L112","Shared Database Schema - both services point at the same bookstore_db schema in local/docker profiles, so a Flyway migration or data repair in one bounded context risks corrupting the other's data set and breaks domain isolation."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/web/CreateOrderResponse.java; bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/OrderItem.java","Response:L25-L39; Item:L23-L52","Broken Abstraction - REST responses return JPA entities (OrderItem, OrderBillingAddress, OrderShippingAddress) directly, leaking persistence annotations and bidirectional associations to API clients who now depend on internal schema details."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/Cart.java; bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/CartItem.java","Cart:L47-L61; CartItem:L54-L63","Bidirectional Aggregate Coupling - Cart maintains a mutable list of CartItem entities while each CartItem holds a back-reference to its parent and mutates it in lifecycle callbacks, introducing tight coupling that complicates reuse, serialization, and transactional boundaries."
+"docker-compose deployment","docker-compose.yml","L36-L142","Gateway Bypass Risk - the compose file publishes every service port (4001-8001) alongside the Zuul gateway, letting clients call internal services directly and bypass cross-cutting policies (auth, throttling) intended to live at the edge."
+"bookstore-order-service","bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/CartItemServiceImpl.java; bookstore-feign/src/main/java/com/devd/spring/bookstorecommons/web/GetProductResponse.java","CartItemSvc:L41-L107; ProductDTO:L16-L23","Service Intimacy - the cart service pulls full product records over Feign and persists remote fields like price, productName, and availableItemCount into its own entities, baking catalog-domain concepts into the order service and creating hidden data ownership coupling."

architectural_smells.md

@@ -0,0 +1,17 @@
+# Architectural Smells Inventory
+
+| Primary Service / Module | Code File Path (if applicable) | Code Line(s) | Labeling |
+| --- | --- | --- | --- |
+| bookstore-commons module | `bookstore-commons/pom.xml` | L25-L140 | Shared Platform Library - the commons jar wires in validation, JPA, Web MVC, H2, test, Eureka, Consul, Hystrix, OpenFeign, OAuth2, JWT, Swagger, Lombok, and Dozer so every consumer inherits the full runtime stack even when it only needs a utility class, locking services to a monolithic dependency bundle. |
+| bookstore-feign library | `bookstore-feign/pom.xml` | L23-L123 | Shared Platform Library - the Feign helper adds Spring MVC, JPA, H2, tests, Eureka, Hystrix (twice), OpenFeign, OAuth2, Security, JWT, Swagger, and Lombok to expose a few client interfaces, forcing each service that wants one downstream client to accept the entire platform footprint. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/controller/OrderController.java` | L30-L64 | Unversioned API Surface - every REST endpoint (`/order`, `/orders`, `/previewOrder`) is rooted at the service base path without a version prefix, so any breaking change to payloads or semantics immediately breaks all consumers with no opt-in migration path. |
+| bookstore-account-service | `bookstore-account-service/src/main/java/com/devd/spring/bookstoreaccountservice/controller/UserController.java` | L39-L99 | Unversioned API Surface - administrative and self-service operations all live under `/user`, `/users`, and `/userInfo` without `/v1` (or similar), preventing the team from versioning the endpoints independently for back-office and retail clients. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java` | L63-L198 | Unstable Dependency - order creation performs synchronous RPC calls to the billing and payment services for every checkout (`billingFeignClient.getAddressById`, `paymentFeignClient.doPayment`), so any latency spike or API change in those dependencies blocks or fails the transaction end-to-end. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java` | L77-L198 | Greedy Service - `createOrder` fetches addresses, assembles order aggregates, calculates taxes and shipping, triggers payment capture, persists billing and shipping snapshots, and clears the cart, concentrating multiple business capabilities inside one class instead of delegating to focused domain services. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/OrderServiceImpl.java` | L77-L156 | Orchestrator Bottleneck - the order workflow choreographs each remote call (billing lookup, payment authorization) in sequence with no asynchronous handoff, retries, or circuit breaking beyond Hystrix defaults, making the order service a tight coupling point for the entire purchase saga. |
+| bookstore-api-gateway-service | `bookstore-api-gateway-service/src/main/resources/application.yml` | L26-L42 | Hub-like Gateway - Zuul centralises routing for billing, catalog, account, order, and payment domains under a single `/api` prefix, so a gateway outage or misconfiguration brings down every customer-facing capability. |
+| bookstore-account-service & bookstore-order-service | `bookstore-account-service/src/main/resources/application.yml`; `bookstore-order-service/src/main/resources/application.yml` | Account:L60-L115; Order:L68-L112 | Shared Database Schema - both services point at the same `bookstore_db` schema in local/docker profiles, so a Flyway migration or data repair in one bounded context risks corrupting the other's data set and breaks domain isolation. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/web/CreateOrderResponse.java`; `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/OrderItem.java` | Response:L25-L39; Item:L23-L52 | Broken Abstraction - REST responses return JPA entities (`OrderItem`, `OrderBillingAddress`, `OrderShippingAddress`) directly, leaking persistence annotations and bidirectional associations to API clients who now depend on internal schema details. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/Cart.java`; `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/repository/dao/CartItem.java` | Cart:L47-L61; CartItem:L54-L63 | Bidirectional Aggregate Coupling - `Cart` maintains a mutable list of `CartItem` entities while each `CartItem` holds a back-reference to its parent and mutates it in lifecycle callbacks, introducing tight coupling that complicates reuse, serialization, and transactional boundaries. |
+| docker-compose deployment | `docker-compose.yml` | L36-L142 | Gateway Bypass Risk - the compose file publishes every service port (`4001-8001`) alongside the Zuul gateway, letting clients call internal services directly and bypass cross-cutting policies (auth, throttling) intended to live at the edge. |
+| bookstore-order-service | `bookstore-order-service/src/main/java/com/devd/spring/bookstoreorderservice/service/impl/CartItemServiceImpl.java`; `bookstore-feign/src/main/java/com/devd/spring/bookstorecommons/web/GetProductResponse.java` | CartItemSvc:L41-L107; ProductDTO:L16-L23 | Service Intimacy - the cart service pulls full product records over Feign and persists remote fields like `price`, `productName`, and `availableItemCount` into its own entities, baking catalog-domain concepts into the order service and creating hidden data ownership coupling. |

final_arch_smells.csv

@@ -0,0 +1,25 @@
+Smell,Primary Service / Module,Code File Path (if applicable),Code Line(s),labeling justification in details
+"Architectural Smell","bookstore-application-parent","pom.xml","L20-L104","The parent Maven POM declares every microservice module alongside shared logging, tracing, Swagger, and Dozer dependencies, making the supposed microservices compile as a single multi-module build where each service inherits the same stack and cannot evolve independently."
+"Insufficient Modularization","bookstore-commons","bookstore-commons/pom.xml","L23-L138","The commons jar drags in JPA, Web MVC, H2, testing, two Hystrix starters, Eureka, Consul, OAuth2, JWT, Swagger, Lombok, and Dozer just to share utility code, forcing consumers to accept an oversized runtime footprint instead of isolated helpers."
+"Insufficient Modularization","bookstore-feign","bookstore-feign/pom.xml","L23-L123","The dedicated Feign client library repeats the entire Spring Boot web/data stack plus Hystrix, security, OAuth2, Swagger, Lombok, and test tooling simply to publish interface stubs, coupling every service that needs an HTTP client to a platform bundle."
+"Unversioned API","bookstore-order-service","bookstore-order-service/.../controller/OrderController.java","L30-L63","All order endpoints (/order, /orders, /previewOrder) sit at root paths without a version prefix, so any contract change immediately breaks consumers with no way to opt into a new version."
+"Unversioned API","bookstore-billing-service","bookstore-billing-service/.../controller/AddressController.java","L30-L58","The billing controller exposes /address CRUD routes directly, leaving no URI versioning or compatibility buffer for clients consuming stored addresses."
+"Unstable Dependency","bookstore-order-service","bookstore-order-service/.../service/impl/OrderServiceImpl.java","L63-L197","OrderServiceImpl performs synchronous Feign calls to billing and payment services for every checkout, so latency or failures in those downstream systems block order creation end-to-end."
+"Unstable Dependency","bookstore-order-service","bookstore-order-service/.../service/impl/CartItemServiceImpl.java","L55-L86","The cart item workflow eagerly fetches product data over the catalog Feign client before persisting, making order cart updates contingent on catalog availability."
+"Greedy Service","bookstore-order-service","bookstore-order-service/.../service/impl/OrderServiceImpl.java","L77-L197","The same service method fetches addresses, assembles aggregates, calculates tax and shipping, triggers payment capture, persists billing/shipping snapshots, and clears the cart, concentrating multiple bounded contexts in one class."
+"Shared Persistence","bookstore-account-service","bookstore-account-service/src/main/resources/application.yml","L58-L115","Account profiles for H2, local MySQL, and Docker all target the shared bookstore_db schema, so account data migrations collide with other services using the same database."
+"Shared Persistence","bookstore-order-service","bookstore-order-service/src/main/resources/application.yml","L54-L112","Order service datasource profiles reuse the same bookstore_db JDBC URL and credentials, eliminating database per service isolation."
+"Shared Persistence","bookstore-billing-service","bookstore-billing-service/src/main/resources/application.yml","L56-L114","Billing service configurations also point at bookstore_db, confirming three separate bounded contexts persist into the same schema."
+"Hub-like Dependency","bookstore-api-gateway-service","bookstore-api-gateway-service/src/main/resources/application.yml","L21-L46","Zuul routes for billing, catalog, account, order, and payment all terminate at the same gateway prefix with eager Ribbon loading, so one gateway outage fans out across every downstream capability."
+"Hub-like Dependency","bookstore-order-service","bookstore-order-service/.../service/impl/OrderServiceImpl.java","L63-L197","Order orchestration depends on repositories plus billing and payment clients in the same method, making the order service a hub that other domains must stay aligned with."
+"Unnecessary Abstraction","bookstore-feign","bookstore-feign/.../feign/AccountFeignClient.java","L16-L23","The Feign client duplicates the account service routes with method overloads on the same /user path, adding an extra indirection layer without hiding transport details or reducing coupling."
+"Unnecessary Abstraction","bookstore-feign","bookstore-feign/.../feign/CatalogFeignClient.java; bookstore-feign/.../feign/BillingFeignClient.java","Catalog:L15-L16; Billing:L14-L15","These Feign interfaces simply mirror downstream REST signatures, yet the shared library also bundles full web/JPA dependencies, so the abstraction adds little value while enlarging every service."
+"Broken Modularization","bookstore-order-service","bookstore-order-service/.../web/CreateOrderResponse.java","L25-L39","The REST response type exposes JPA entities like OrderItem, OrderBillingAddress, and OrderShippingAddress, leaking persistence annotations and bidirectional associations to API clients."
+"Broken Modularization","bookstore-order-service","bookstore-order-service/.../service/impl/OrderServiceImpl.java","L113-L193","The service copies persistence entities directly into response DTOs and saves billing/shipping records mid-request, binding transport contracts to internal entity structure."
+"Cyclic Dependency","bookstore-order-service","bookstore-order-service/.../repository/dao/Cart.java; bookstore-order-service/.../repository/dao/CartItem.java","Cart:L47-L60; CartItem:L54-L63","Cart holds a mutable list of CartItem entities while each CartItem keeps a back-reference and manually severs the relationship in lifecycle callbacks, creating a bidirectional entity cycle."
+"ESB Usage","bookstore-api-gateway-service","bookstore-api-gateway-service/src/main/resources/application.yml","L21-L58","The Zuul gateway centralizes routing, timeout, and Hystrix thread isolation policies for every downstream service, effectively acting as an enterprise service bus that mediates all traffic and cross-cutting concerns."
+"ESB Usage","bookstore-feign","bookstore-feign/pom.xml; bookstore-feign/.../feign/*.java","Pom:L23-L123; Clients:L13-L23","Consolidating every cross-service client and resilience dependency into a single shared library recreates an integration bus, funneling inter-service communication through one deployable artifact."
+"No API Gateway","docker-compose deployment","docker-compose.yml","L36-L142","Docker compose publishes each microservice container on host ports (4001-8001) alongside Zuul, allowing clients to bypass the gateway entirely despite the intended edge routing."
+"No API Gateway","bookstore-frontend-react-app","bookstore-frontend-react-app/src/constants/appConstants.js","L1-L3","The SPA hardcodes gateway credentials and URL, so distributing the client leaks secrets and encourages direct calls that can sidestep centralized ingress controls."
+"Service Imitation","bookstore-order-service","bookstore-order-service/.../service/impl/CartItemServiceImpl.java","L55-L86","The cart service copies catalog data (productName, price, availableItemCount) into its own entities, duplicating catalog responsibilities instead of referencing them."
+"Service Imitation","bookstore-payment-service","bookstore-payment-service/.../service/impl/PaymentsServiceImpl.java; bookstore-payment-service/.../service/impl/PaymentMethodServiceImpl.java","Payments:L42-L70; PaymentMethods:L63-L177","Payment services proxy Stripe APIs almost verbatim—creating intents, customers, and payment methods with no additional domain rules—so the microservice imitates an upstream provider rather than encapsulating unique business logic."