Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go & Go-postgres: Support 1.21 and drop buster #194

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

whuwxl
Copy link
Contributor

@whuwxl whuwxl commented Aug 11, 2023

This PR updates Go to version 1.21 and removes 'buster' from golang tags, following upstream's drop of 'buster' support. Ref: docker-library/golang@cd60713

@whuwxl whuwxl requested a review from a team as a code owner August 11, 2023 04:19
@whuwxl
Copy link
Contributor Author

whuwxl commented Aug 11, 2023

@microsoft-github-policy-service agree

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to contribute this PR, appreciate it ❇️
left some comments!

src/go-postgres/devcontainer-template.json Show resolved Hide resolved
src/go-postgres/devcontainer-template.json Outdated Show resolved Hide resolved
src/go-postgres/devcontainer-template.json Outdated Show resolved Hide resolved
src/go-postgres/devcontainer-template.json Outdated Show resolved Hide resolved
src/go-postgres/devcontainer-template.json Show resolved Hide resolved
src/go/devcontainer-template.json Show resolved Hide resolved
src/go-postgres/devcontainer-template.json Outdated Show resolved Hide resolved
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is in great shape, thanks!
I'd help approve once the dev container images are released. Dev tags are getting pushed, hoping to release the prod tags on Monday.

@whuwxl
Copy link
Contributor Author

whuwxl commented Aug 11, 2023

@samruddhikhandale Thanks a bunch for diving into my PR and sharing your valuable feedback! I've picked up some great insights from it. 😄👍

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 ⚡

@samruddhikhandale samruddhikhandale merged commit e4b96bd into devcontainers:main Aug 15, 2023
4 checks passed
@whuwxl whuwxl deleted the go_1.21 branch August 21, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants