Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] fixes broken link #257

Merged

Conversation

MarvinGravert
Copy link
Contributor

Hi,

i have noticed that the link to the schema which is referenced in contributing.md and devcontainerjson-reference.md is broken. It links to a devContainer.schema.src.json file that no longer exists in the vscode repo (removed in this PR).

I have adjusted the docs to link to the devContainer.base.schema.json which is found in this repo.

I hope this is correct. If not, sorry for any inconvenience.

@MarvinGravert MarvinGravert requested a review from a team as a code owner June 16, 2023 20:27
@MarvinGravert
Copy link
Contributor Author

@microsoft-github-policy-service agree

@bamurtaugh
Copy link
Member

Thanks so much for opening this @MarvinGravert! I believe this should be updated to https://github.com/microsoft/vscode/blob/main/extensions/configuration-editing/schemas/devContainer.vscode.schema.json - would you be able to update your PR? Thanks!

@MarvinGravert
Copy link
Contributor Author

MarvinGravert commented Jun 19, 2023

Thanks for your feedback @bamurtaugh ! I have changed the link to your recommendation.

This reverts commit 0963c82.
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants