-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] fixes broken link #257
[Docs] fixes broken link #257
Conversation
@microsoft-github-policy-service agree |
Thanks so much for opening this @MarvinGravert! I believe this should be updated to https://github.com/microsoft/vscode/blob/main/extensions/configuration-editing/schemas/devContainer.vscode.schema.json - would you be able to update your PR? Thanks! |
Thanks for your feedback @bamurtaugh ! I have changed the link to your recommendation. |
This reverts commit 0963c82.
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hi,
i have noticed that the link to the schema which is referenced in
contributing.md
anddevcontainerjson-reference.md
is broken. It links to adevContainer.schema.src.json
file that no longer exists in the vscode repo (removed in this PR).I have adjusted the docs to link to the
devContainer.base.schema.json
which is found in this repo.I hope this is correct. If not, sorry for any inconvenience.