Skip to content

Conversation

@prulloac
Copy link
Contributor

@prulloac prulloac commented Sep 26, 2023

Resolves #639

main.sh first checks if user has home directory already set and different than /home/${USERNAME}. if it does, then uses the custom home directory, otherwise behaves as usual

@prulloac prulloac marked this pull request as ready for review September 26, 2023 02:07
@prulloac prulloac requested a review from a team as a code owner September 26, 2023 02:07
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, we appreciate it ✨

Left some minor comments, besides that looks good to me.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🎉

@samruddhikhandale samruddhikhandale merged commit e7f7d19 into devcontainers:main Sep 27, 2023
@prulloac prulloac deleted the common-utils-home branch September 28, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

common-utils doesn't handle custom $HOME locations

2 participants